Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Error handling #72

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Remove Error handling #72

merged 1 commit into from
Dec 17, 2023

Conversation

dhschall
Copy link
Contributor

@dhschall dhschall commented Aug 2, 2023

Instead of failing right away the grpcclient
returns an empty message and the error.
Now the client (relay) that implements the
grpcclient is responsibe to handle the error

@dhschall dhschall added the enhancement New feature or request label Aug 2, 2023
@dhschall dhschall self-assigned this Aug 2, 2023
@dhschall dhschall requested a review from harshitgarg22 August 2, 2023 09:09
@dhschall
Copy link
Contributor Author

dhschall commented Aug 2, 2023

This is required for vhive-serverless/vSwarm#634
which fixes vhive-serverless/vSwarm#629

Instead of failing right away the grpcclient
returns an empty message and the error.
Now the client (relay) that implements the
grpcclient is responsibe to handle the error

Signed-off-by: David Schall <[email protected]>
@dhschall dhschall merged commit 6caa092 into main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant